-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move config path to "script-opts" #3
base: master
Are you sure you want to change the base?
Conversation
Are the scripts working for you with mpv 0.33+ ? |
yes, but i don't want to maintain two different options folder. |
I think this repo's maintainer is long unresponsive. Anyway I could not get Blackbox.js or other scripts from this repo even with your patch to run on the newer mpv. |
emm, I thought you were a maintainer, anyway, this is going to be off-topic. Try add following script into your // deprecated directory
mp.module_paths.unshift("~~/scripts/modules.js"); Below to reproduce:$ mpv --version
mpv 0.33.1-dirty Copyright © 2000-2020 mpv/MPlayer/mplayer2 projects
built on UNKNOWN
FFmpeg library versions:
libavutil 56.70.100
libavcodec 58.134.100
libavformat 58.76.100
libswscale 5.9.100
libavfilter 7.110.100
libswresample 3.9.100
FFmpeg version: n4.4
$ git clone https://github.com/VideoPlayerCode/mpv-tools /tmp/mpv-tools
$ cd /tmp/mpv-tools
$ cat <<EOF > .init.js
// deprecated directory
mp.module_paths.unshift("~~/scripts/modules.js");
EOF
$ cat <<EOF > input.conf
ctrl+b script-binding Blackbox
ctrl+f script-binding Blackbox_Favorites
EOF
$ ffmpeg -f lavfi -i testsrc=duration=10:size=1280x720:rate=30 sample.mp4
$ mpv --config-dir=. sample.mp4
// press "ctrl+b" open Blackbox menu |
That got it working for me again thanks! I didn't know ~/scripts/modules.js was deprecated. So what does the unshift do to that path ? |
Is it a problem to keep script and script-opts... |
And what is the updated fork that i can use?? |
First time trying to get MPV working with Colorbox. Downloaded your commits for new folder name (script-opts), and following VideoPlayerCode Install-Notes instructions here for renaming Colorbox.js to main.js etc. results in broken functionality of video tools. Following errors in log: [ 0.060][d][global] user path: '/Users/xxxx/.config/mpv/scripts/Colorbox/modules/Options.js' -> '/Users/xxxx/.config/mpv/scripts/Colorbox/modules/Options.js' Any ideas please? Thanks. |
Now mpv uses directory "script-opts/" as config path, which we should follow.